feat: Add default CI to Fuel Category #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Dec 18, 2024
dhaselhan
commented
- Default CI is actually associated to fuel category and used as a fallback in several scenarios
- The one covered here is Other, where if the user selects other it needs to use the CI of the Cateory, NOT the Type.
* Default CI is actually associated to fuel category and used as a fallback in several scenarios * The one covered here is Other, where if the user selects other it needs to use the CI of the Cateory, NOT the Type.
dhaselhan
requested review from
AlexZorkin and
kevin-hashimoto
and removed request for
AlexZorkin
Frontend Test Results 1 files ±0 116 suites ±0 38s ⏱️ -1s For more details on these failures, see this check. Results for commit a2d2293. ± Comparison against base commit cf6599e. ♻️ This comment has been updated with latest results. |
kevin-hashimoto
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.